-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior, utilize internalized CRC32C utilities #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
Pull request size is extra large.
api: storage
Issues related to the googleapis/nodejs-storage API.
labels
Apr 15, 2022
shaffeeullah
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Apr 15, 2022
shaffeeullah
changed the title
BREAKING CHANGE!: drop node 10 support, remove deprecated fields, remove configstore
BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore
Apr 15, 2022
shaffeeullah
changed the title
BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore
BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior
Apr 15, 2022
shaffeeullah
changed the title
BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior
fix!: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior
Apr 15, 2022
Warning: This pull request is touching the following templated files:
|
danielbankhead
changed the title
fix!: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior
fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior
May 5, 2022
danielbankhead
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
May 19, 2022
danielbankhead
changed the title
fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior
fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior, utilize internalized CRC32C utilities
May 19, 2022
ddelgrosso1
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 19, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 19, 2022
* chore: removed deprecated fields * cleaned up tests * removed unused vars * linted files
* fix: default to resumable with no threshold * fix documentaiton * linted file * fixed documentation typo
* fix: remove configstore * removed unused varaibles * remove xdg-basedir
* refactor: remove unnecessary types * removed types
* fix: update typescript to 4.6.3 and fix resulting errors * remove unused variables * use http error instead of any
* test: disable resumable upload in acl test before (#1903) * build: Streamline `mocha` config (#1905) * build: Streamline `mocha` config * fix: Require `--require ts-node/register` first * refactor: Misc cleanup Co-authored-by: Denis DelGrosso <[email protected]>
* test: add performance measuring * add threading support to performance tests * linter fixes * rename folder * add precondition to uploads, write to file for downloads * fix pathing * review feedback * linter * disable no unsupported features error now node 10 is unsupported * add jsdoc headers
* chore(deps): update promisify to 3.0 * update retry-request to 5.0 * revert mocha to ^9.2.2
* feat: Create CRC32C Utility * feat: Export `CRC32C` utilities * docs: Doc updates/clarifications * feat: validate numbers Plus, documentation updates * test: Add tests for `CRC32C` * test: Add system-test for `CRC32C` * test: Add system-test for `CRC32C`
* feat!: Use `HashStreamValidator` for stream validation - Removes `fast-crc32c` support * fix: remove logs * test: `crc32cGenerator` option * test: improve `compression` test reliability * chore: add temp debug logs * chore: more debug logs * fix: use static gzip content to remove test variance * chore: remove debug logs * chore: lint
ddelgrosso1
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 23, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 23, 2022
ddelgrosso1
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
May 23, 2022
ddelgrosso1
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 23, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 23, 2022
shaffeeullah
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
May 24, 2022
ddelgrosso1
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1856
Note: all code on this branch has already been reviewed and approved. All incoming changes should be merged in via a PR into this branch.