Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior, utilize internalized CRC32C utilities #1876

Merged
merged 16 commits into from
May 24, 2022

Conversation

shaffeeullah
Copy link
Contributor

@shaffeeullah shaffeeullah commented Apr 15, 2022

Fixes: #1856

Note: all code on this branch has already been reviewed and approved. All incoming changes should be merged in via a PR into this branch.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 15, 2022
@shaffeeullah shaffeeullah added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 15, 2022
@shaffeeullah shaffeeullah changed the title BREAKING CHANGE!: drop node 10 support, remove deprecated fields, remove configstore BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore Apr 15, 2022
@shaffeeullah shaffeeullah changed the title BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior Apr 15, 2022
@shaffeeullah shaffeeullah changed the title BREAKING CHANGE: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior fix!: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior Apr 15, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@danielbankhead danielbankhead changed the title fix!: drop node 10 support, remove deprecated fields, remove configstore, align resumable upload behavior fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior May 5, 2022
@danielbankhead danielbankhead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 19, 2022
@danielbankhead danielbankhead changed the title fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior fix!: drop node 10 support, update TypeScript, remove deprecated fields, remove configstore, align resumable upload behavior, utilize internalized CRC32C utilities May 19, 2022
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2022
shaffeeullah and others added 15 commits May 23, 2022 15:56
* chore: removed deprecated fields

* cleaned up tests

* removed unused vars

* linted files
* fix: default to resumable with no threshold

* fix documentaiton

* linted file

* fixed documentation typo
* fix: remove configstore

* removed unused varaibles

* remove xdg-basedir
* refactor: remove unnecessary types

* removed types
* fix: update typescript to 4.6.3 and fix resulting errors

* remove unused variables

* use http error instead of any
* test: disable resumable upload in acl test before (#1903)

* build: Streamline `mocha` config (#1905)

* build: Streamline `mocha` config

* fix: Require `--require ts-node/register` first

* refactor: Misc cleanup

Co-authored-by: Denis DelGrosso <[email protected]>
* test: add performance measuring

* add threading support to performance tests

* linter fixes

* rename folder

* add precondition to uploads, write to file for downloads

* fix pathing

* review feedback

* linter

* disable no unsupported features error now node 10 is unsupported

* add jsdoc headers
* chore(deps): update promisify to 3.0

* update retry-request to 5.0

* revert mocha to ^9.2.2
* feat: Create CRC32C Utility

* feat: Export `CRC32C` utilities

* docs: Doc updates/clarifications

* feat: validate numbers

Plus, documentation updates

* test: Add tests for `CRC32C`

* test: Add system-test for `CRC32C`

* test: Add system-test for `CRC32C`
* feat!: Use `HashStreamValidator` for stream validation

- Removes `fast-crc32c` support

* fix: remove logs

* test: `crc32cGenerator` option

* test: improve `compression` test reliability

* chore: add temp debug logs

* chore: more debug logs

* fix: use static gzip content to remove test variance

* chore: remove debug logs

* chore: lint
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@ddelgrosso1 ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 23, 2022
@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review May 23, 2022 21:27
@ddelgrosso1 ddelgrosso1 requested review from a team as code owners May 23, 2022 21:27
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2022
@shaffeeullah shaffeeullah removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Node 10 and make Node 12 the minimal version.
6 participants